This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 1/8] Language independent bits
On Sun, Jan 15, 2012 at 12:34 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
>> +
>> + ? ?struct expression *expout;
>> +
>> + ? ?/* The size of the expression above. ?*/
>> +
>> + ? ?int expout_size;
>
> Memory object size does not fit into `int', it should be `size_t'.
>
>
>> +
>> + ? ?/* The number of elements already in the expression. ?This is used
>> + ? ? ? to know where to put new elements. ?*/
>> +
>> + ? ?int expout_ptr;
>
> Likewise.
Sure, but I think this is excessively nitpicky.
Each element is (at least) 16 bytes in size and gdb has been using
ints just fine so far.