This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit, s390] Use "GNU/Linux" (Re: New ARI warning Wed Dec 7 01:55:04 UTC 2011)
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 7 Dec 2011 14:35:00 +0100 (CET)
- Subject: [commit, s390] Use "GNU/Linux" (Re: New ARI warning Wed Dec 7 01:55:04 UTC 2011)
> gdb/s390-tdep.c:429: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/s390-tdep.c:429: /* Linux-specific optional "registers". */
[...]
Oops, I forgot about that. Fixed by the patch below.
Committed to mainline.
> gdb/s390-tdep.c:3148: deprecate: write_pc: Replace write_pc() with get_frame_base_address or get_frame_id; at present the inferior function call code still uses this when doing a DECR_PC_AFTER_BREAK
> gdb/s390-tdep.c:3148: set_gdbarch_write_pc (gdbarch, s390_write_pc);
This is actually a false positive. The real "write_pc" routine this
check is worried about doesn't even exist in the sources any more;
this check ought to be simply deleted.
Bye,
Ulrich
ChangeLog:
* s390-tdep.c: Replace "Linux" by "GNU/Linux" in comments
where appropriate.
* s390-tdep.h: Likewise.
Index: gdb/s390-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/s390-tdep.c,v
retrieving revision 1.200
diff -u -p -r1.200 s390-tdep.c
--- gdb/s390-tdep.c 6 Dec 2011 14:14:48 -0000 1.200
+++ gdb/s390-tdep.c 7 Dec 2011 13:26:28 -0000
@@ -170,7 +170,7 @@ static int s390_dwarf_regmap[] =
S390_R8_REGNUM, S390_R9_REGNUM, S390_R10_REGNUM, S390_R11_REGNUM,
S390_R12_REGNUM, S390_R13_REGNUM, S390_R14_REGNUM, S390_R15_REGNUM,
- /* Linux-specific registers (not mapped). */
+ /* GNU/Linux-specific registers (not mapped). */
-1, -1, -1,
};
@@ -426,7 +426,7 @@ int s390_regmap_gregset[S390_NUM_REGS] =
/* GPR Uppper Halves. */
-1, -1, -1, -1, -1, -1, -1, -1,
-1, -1, -1, -1, -1, -1, -1, -1,
- /* Linux-specific optional "registers". */
+ /* GNU/Linux-specific optional "registers". */
0x88, -1, -1,
};
@@ -454,7 +454,7 @@ int s390x_regmap_gregset[S390_NUM_REGS]
0x30, 0x38, 0x40, 0x48,
0x50, 0x58, 0x60, 0x68,
0x70, 0x78, 0x80, 0x88,
- /* Linux-specific optional "registers". */
+ /* GNU/Linux-specific optional "registers". */
0xd0, -1, -1,
};
@@ -478,7 +478,7 @@ int s390_regmap_fpregset[S390_NUM_REGS]
/* GPR Uppper Halves. */
-1, -1, -1, -1, -1, -1, -1, -1,
-1, -1, -1, -1, -1, -1, -1, -1,
- /* Linux-specific optional "registers". */
+ /* GNU/Linux-specific optional "registers". */
-1, -1, -1,
};
@@ -502,7 +502,7 @@ int s390_regmap_upper[S390_NUM_REGS] =
0x10, 0x14, 0x18, 0x1c,
0x20, 0x24, 0x28, 0x2c,
0x30, 0x34, 0x38, 0x3c,
- /* Linux-specific optional "registers". */
+ /* GNU/Linux-specific optional "registers". */
-1, -1, -1,
};
@@ -524,7 +524,7 @@ int s390_regmap_last_break[S390_NUM_REGS
/* GPR Uppper Halves. */
-1, -1, -1, -1, -1, -1, -1, -1,
-1, -1, -1, -1, -1, -1, -1, -1,
- /* Linux-specific optional "registers". */
+ /* GNU/Linux-specific optional "registers". */
-1, 4, -1,
};
@@ -546,7 +546,7 @@ int s390x_regmap_last_break[S390_NUM_REG
/* GPR Uppper Halves. */
-1, -1, -1, -1, -1, -1, -1, -1,
-1, -1, -1, -1, -1, -1, -1, -1,
- /* Linux-specific optional "registers". */
+ /* GNU/Linux-specific optional "registers". */
-1, 0, -1,
};
@@ -568,7 +568,7 @@ int s390_regmap_system_call[S390_NUM_REG
/* GPR Uppper Halves. */
-1, -1, -1, -1, -1, -1, -1, -1,
-1, -1, -1, -1, -1, -1, -1, -1,
- /* Linux-specific optional "registers". */
+ /* GNU/Linux-specific optional "registers". */
-1, -1, 0,
};
@@ -3068,7 +3068,7 @@ s390_gdbarch_init (struct gdbarch_info i
valid_p &= tdesc_numbered_register (feature, tdesc_data,
S390_A0_REGNUM + i, acrs[i]);
- /* Optional Linux-specific "registers". */
+ /* Optional GNU/Linux-specific "registers". */
feature = tdesc_find_feature (tdesc, "org.gnu.gdb.s390.linux");
if (feature)
{
@@ -3290,7 +3290,7 @@ _initialize_s390_tdep (void)
/* Hook us into the gdbarch mechanism. */
register_gdbarch_init (bfd_arch_s390, s390_gdbarch_init);
- /* Initialize the Linux target descriptions. */
+ /* Initialize the GNU/Linux target descriptions. */
initialize_tdesc_s390_linux32 ();
initialize_tdesc_s390_linux32v1 ();
initialize_tdesc_s390_linux32v2 ();
Index: gdb/s390-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/s390-tdep.h,v
retrieving revision 1.10
diff -u -p -r1.10 s390-tdep.h
--- gdb/s390-tdep.h 6 Dec 2011 14:14:48 -0000 1.10
+++ gdb/s390-tdep.h 7 Dec 2011 13:26:28 -0000
@@ -95,7 +95,7 @@
#define S390_R13_UPPER_REGNUM 64
#define S390_R14_UPPER_REGNUM 65
#define S390_R15_UPPER_REGNUM 66
-/* Linux-specific optional registers. */
+/* GNU/Linux-specific optional registers. */
#define S390_ORIG_R2_REGNUM 67
#define S390_LAST_BREAK_REGNUM 68
#define S390_SYSTEM_CALL_REGNUM 69
@@ -118,7 +118,7 @@ extern int s390_regmap_last_break[S390_N
extern int s390x_regmap_last_break[S390_NUM_REGS];
extern int s390_regmap_system_call[S390_NUM_REGS];
-/* Linux target descriptions. */
+/* GNU/Linux target descriptions. */
extern struct target_desc *tdesc_s390_linux32;
extern struct target_desc *tdesc_s390_linux32v1;
extern struct target_desc *tdesc_s390_linux32v2;
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com