This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 022/238] [misc.] bcache.c: -Wshadow fix.
Cause:
Clashes with `bcache' function from "bcache.h".
To ChangeLog:
* bcache.c (expand_hash_table): Rename `bcache' to `cache'(-Wshadow).
---
gdb/ChangeLog | 5 +++++
gdb/bcache.c | 30 +++++++++++++++---------------
2 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4ce5f86..57ee41f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2011-11-22 Andrey Smirnov <andrew.smirnov@gmail.com>
+ * bcache.c (expand_hash_table): Fix -Wshadow
+ warnings.
+
+2011-11-22 Andrey Smirnov <andrew.smirnov@gmail.com>
+
* annotate.c (annotate_array_section_begin): Fix -Wshadow
warnings.
diff --git a/gdb/bcache.c b/gdb/bcache.c
index 76e3893..5c287d9 100644
--- a/gdb/bcache.c
+++ b/gdb/bcache.c
@@ -130,7 +130,7 @@ hash_continue (const void *addr, int length, unsigned long h)
#define CHAIN_LENGTH_THRESHOLD (5)
static void
-expand_hash_table (struct bcache *bcache)
+expand_hash_table (struct bcache *cache)
{
/* A table of good hash table sizes. Whenever we grow, we pick the
next larger size from this table. sizes[i] is close to 1 << (i+10),
@@ -149,13 +149,13 @@ expand_hash_table (struct bcache *bcache)
/* Count the stats. Every unique item needs to be re-hashed and
re-entered. */
- bcache->expand_count++;
- bcache->expand_hash_count += bcache->unique_count;
+ cache->expand_count++;
+ cache->expand_hash_count += cache->unique_count;
/* Find the next size. */
- new_num_buckets = bcache->num_buckets * 2;
+ new_num_buckets = cache->num_buckets * 2;
for (i = 0; i < (sizeof (sizes) / sizeof (sizes[0])); i++)
- if (sizes[i] > bcache->num_buckets)
+ if (sizes[i] > cache->num_buckets)
{
new_num_buckets = sizes[i];
break;
@@ -168,22 +168,22 @@ expand_hash_table (struct bcache *bcache)
new_buckets = (struct bstring **) xmalloc (new_size);
memset (new_buckets, 0, new_size);
- bcache->structure_size -= (bcache->num_buckets
- * sizeof (bcache->bucket[0]));
- bcache->structure_size += new_size;
+ cache->structure_size -= (cache->num_buckets
+ * sizeof (cache->bucket[0]));
+ cache->structure_size += new_size;
}
/* Rehash all existing strings. */
- for (i = 0; i < bcache->num_buckets; i++)
+ for (i = 0; i < cache->num_buckets; i++)
{
struct bstring *s, *next;
- for (s = bcache->bucket[i]; s; s = next)
+ for (s = cache->bucket[i]; s; s = next)
{
struct bstring **new_bucket;
next = s->next;
- new_bucket = &new_buckets[(bcache->hash_function (&s->d.data,
+ new_bucket = &new_buckets[(cache->hash_function (&s->d.data,
s->length)
% new_num_buckets)];
s->next = *new_bucket;
@@ -192,10 +192,10 @@ expand_hash_table (struct bcache *bcache)
}
/* Plug in the new table. */
- if (bcache->bucket)
- xfree (bcache->bucket);
- bcache->bucket = new_buckets;
- bcache->num_buckets = new_num_buckets;
+ if (cache->bucket)
+ xfree (cache->bucket);
+ cache->bucket = new_buckets;
+ cache->num_buckets = new_num_buckets;
}
--
1.7.5.4