This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] arm reversible : <phase_2_complete>
- From: Petr HluzÃn <petr dot hluzin at gmail dot com>
- To: Tom Tromey <tromey at redhat dot com>, chandra krishnappa <chandra_roadking at yahoo dot com>
- Cc: oza Pawandeep <oza dot pawandeep at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 5 Nov 2011 18:35:33 +0100
- Subject: Re: [PATCH] arm reversible : <phase_2_complete>
- References: <998639.46560.qm@web112516.mail.gq1.yahoo.com> <m3fwnusq4e.fsf@fleche.redhat.com> <321260.58442.qm@web112504.mail.gq1.yahoo.com> <m3hb6rfc5j.fsf@fleche.redhat.com> <1316327455.23344.YahooMailNeo@web112509.mail.gq1.yahoo.com> <1316404058.27177.YahooMailNeo@web112502.mail.gq1.yahoo.com> <m3pqhzcowx.fsf@fleche.redhat.com> <1318650316.91503.YahooMailNeo@web112508.mail.gq1.yahoo.com> <CAC=yr6D+d-Q4Yzfm6AoWSYgb4+Bopubg4wFDX9QDSUUFFcFtWg@mail.gmail.com> <CAK1A=4yA-kGtnS8BGU+9L7CHXCoMn5MG8sFr++hXvQjKEptrCw@mail.gmail.com> <CAK1A=4yvDqEOYH7gzUoLB+-=S_GSV=EMno=Wq9Y+17feSZN+aQ@mail.gmail.com> <m3fwi5rtnl.fsf@fleche.redhat.com>
On 3 November 2011 18:40, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Oza" == oza Pawandeep <oza.pawandeep@gmail.com> writes:
> I read the whole thread and I think at this point there are still some
> unaddressed comments. ÂIf I am incorrect, could you point me to the most
> up-to-date version of the patch? ÂThen I will review it. ÂOtherwise I
> will wait for your next mail. ÂThanks.
The most recent version of Oza's patch is at [1], my review is at [2].
Oza fixed all issues. (I do not check whitespace, though.) Oza removed
the assertions as you asked, however I believe they should have stayed
(as I explained in mail few minutes ago and in [3]).
However Oza improved ARM extension space insn support which introduced
some bugs - I think, I have no feedback from Oza whether I
misunderstood the code.
[1] http://sourceware.org/ml/gdb-patches/2011-10/msg00613.html
[2] http://sourceware.org/ml/gdb-patches/2011-10/msg00617.html
[3] http://sourceware.org/ml/gdb-patches/2011-10/msg00449.html
--
Petr Hluzin