This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obv] testsuite: Fix gdb.base/skip-solib.exp run


Hi,

+Running gdb/testsuite/gdb.base/skip-solib.exp ...
+ERROR: (gdb/testsuite.unix.-m64/gdb.base/skip-solib-test) No such file or directory
+UNRESOLVED: gdb.base/skip-solib.exp: ignoring file in solib
[FAILs]
+ERROR: (gdb/testsuite.unix.-m64/gdb.base/skip-solib-test) No such file or directory
+UNRESOLVED: gdb.base/skip-solib.exp: ignoring function in solib
[FAILs]

It is the common problem clean_restart does not take subdirectories while other
functions do.  Checked in as obvious.

It usually work for the submitter by loading a stale build which is no longer
being rebuilt during testing.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-11/msg00011.html

--- src/gdb/testsuite/ChangeLog	2011/11/02 04:12:56	1.2921
+++ src/gdb/testsuite/ChangeLog	2011/11/02 08:43:39	1.2922
@@ -1,3 +1,10 @@
+2011-11-02  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.base/skip-solib.exp (executable_main): New variable.
+	(binfile_main): Base it on that.
+	Use $executable_main in clean_restart calls.  Drop gdb_exit and
+	gdb_start calls.
+
 2011-11-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Fix racy FAILs.
@@ -14,13 +21,13 @@
 2011-11-01  Justin Lebar <justin.lebar@gmail.com>
 
 	Add tests for skip command.
-	* testsuite/gdb.base/skip-solib-lib.c: New
-	* testsuite/gdb.base/skip-solib-main.c: New
-	* testsuite/gdb.base/skip-solib.exp: New
-	* testsuite/gdb.base/skip.c: New
-	* testsuite/gdb.base/skip.exp: New
-	* testsuite/gdb.base/skip1.c: New
-	* testsuite/gdb.base/Makefile.in: Adding new files.
+	* gdb.base/skip-solib-lib.c: New
+	* gdb.base/skip-solib-main.c: New
+	* gdb.base/skip-solib.exp: New
+	* gdb.base/skip.c: New
+	* gdb.base/skip.exp: New
+	* gdb.base/skip1.c: New
+	* gdb.base/Makefile.in: Adding new files.
 
 2011-10-31  Yao Qi  <yao@codesourcery.com>
 	    Pedro Alves  <pedro@codesourcery.com>
--- src/gdb/testsuite/gdb.base/skip-solib.exp	2011/11/01 14:51:25	1.1
+++ src/gdb/testsuite/gdb.base/skip-solib.exp	2011/11/02 08:43:40	1.2
@@ -26,7 +26,8 @@
 
 set test "skip-solib"
 set srcfile_main "${test}-main.c"
-set binfile_main "${test}-test"
+set executable_main ${test}-test
+set binfile_main ${objdir}/${subdir}/${executable_main}
 set srcfile_lib "${test}-lib.c"
 set libname "lib${test}"
 set binfile_lib ${objdir}/${subdir}/${libname}.so
@@ -52,8 +53,7 @@
     return -1
 }
 
-gdb_start
-clean_restart ${binfile_main}
+clean_restart ${executable_main}
 
 #
 # At this point, if we try to skip the file ${srcfile_lib} or the function
@@ -96,9 +96,7 @@
 #
 # Now restart gdb and testing ignoring of a function inside a solib.
 #
-gdb_exit
-gdb_start
-clean_restart ${binfile_main}
+clean_restart ${executable_main}
 
 gdb_test "skip function multiply" \
   "Function multiply will be skipped when stepping, pending shared library load." \


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]