This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Status of 'blacklist' patch?
On 10/31/11 6:28 AM, Justin Lebar wrote:
Thanks, this version is ok.
Is this final approval on the patch, or are we waiting on something else?
I was going to say it was ready to go in, but then I noticed these in
skip.c:
+ /* Default to the current function if no argument is given. */
We like to have two spaces after the period. (Yes, it's borderline OCD, but we avoid source churn and confusing diffs if we prescribe this level of consistency.)
There might be other things to fix, but at this point I think it's more efficient to push the code in and start getting it some real-world exercise.
If the former, how do I check in?
Somebody else can commit it for you, but if you intend to be an ongoing
contributor, you need an account on sourceware.org (see
http://sourceware.org/ for instructions), and then set up a read-write
checkout, per http://sourceware.org/gdb/current/ , and check in from there.
Stan
stan@codesourcery.com