This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix handling of qtsave responses
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Luis Machado <luis_gustavo at mentor dot com>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <pedro at codesourcery dot com>
- Date: Wed, 12 Oct 2011 23:49:59 +0200
- Subject: Re: [PATCH] Fix handling of qtsave responses
- References: <4E82BF3C.6090105@mentor.com>
On Wed, 28 Sep 2011 08:31:24 +0200, Luis Machado wrote:
> It has been approved off-list by Pedro.
I agree - just I haven't found it checked in yet.
Thanks,
Jan
> 2011-09-28 Luis Machado <lgustavo@codesourcery.com>
>
> * remote.c (remote_save_trace_data): Invert comparison.
[...]
> reply = remote_get_noisy_reply (&target_buf, &target_buf_size);
> - if (*reply != '\0')
> + if (*reply == '\0')
> error (_("Target does not support this command."));
> if (strcmp (reply, "OK") != 0)
> error (_("Bogus reply from target: %s"), reply);