This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Handle multiple breakpoint hits in Python interface


> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Thu, 1 Sep 2011 10:35:42 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
> 
> +  ** The "gdb.breakpoint" function has been deprecated and in favor of
> +     "gdb.breakpoints".

Without the "and", this is okay.

> +@code{gdb.BreakpointEvent} event indicates that one or several breakpoints have
                                                   ^^^^^^^^^^^^^^
"one or more"

> +@defivar BreakpointEvent breakpoints
> +A sequence containing references to all the breakpoints (type 
> +@code{gdb.Breakpoint}) that were hit.
>  @xref{Breakpoints In Python}, for details of the @code{gdb.Breakpoint} object.
> +@defivar BreakpointEvent breakpoint

This cannot be right: each @defivar should end with the corresponding
"@end defivar".  Didn't makeinfo bitch at you?

> +A reference to the first breakpoint that was hit of type @code{gdb.Breakpoint}.

As opposed to what? watchpoints, catchpoints etc.?  IOW, why do you
need to mention the type issue?

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]