This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/7] Platform agnostic dynamic loading code.


>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> 	* gdb/Makefile.in: Add gdb-dlfcn.c and gdb-dlfcn.h to build
Sanjoy> 	system.
Sanjoy> 	* gdb/config.in: Add new #define HAVE_DLFCN_H.
Sanjoy> 	* gdb/configure.ac: Add check for dlopen and for dlfcn.h
Sanjoy> 	* gdb/configure: Re-generated by autoconf.

Sanjoy> +AC_SEARCH_LIBS(dlopen, dl)
Sanjoy> +AC_CHECK_HEADERS([dlfcn.h])

There is one big call to AC_CHECK_HEADERS in gdb/configure.ac.
Search for "Checks for header files".

You should just add this header to that check; that is where all the
simple checks should go since having them in a single call makes the
resulting configure file smaller.

Sanjoy> +#include "gdb-dlfcn.h"
Sanjoy> +
Sanjoy> +#include "defs.h"

Put defs.h first.

This is ok with those changes.  Thanks.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]