This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: combine bfd_lookup_symbol in solib-*.c


Thanks.

On Monday 29 August 2011 17:22:49, Yao Qi wrote:
> +CORE_ADDR
> +gdb_bfd_lookup_symbol (bfd *abfd,
> +                      int (*match_sym) (asymbol *, const void *),
> +                      const void *data)
> +{

The patch is okay if you remove the "const"s.  It's common to
want to increment a counter in `data' or something like that.

(Try `$ grep iterate_over_ *.h' to see other examples of the pattern).

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]