Re: [patch] Fix target-async SIGTTOU stop (PR 12260)

[Matt Rice <ratmice at gmail dot com>]

On Mon, Aug 29, 2011 at 8:17 AM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Wednesday 24 August 2011 06:24:36, Matt Rice wrote:
>> On Tue, Aug 23, 2011 at 12:31 PM, Jan Kratochvil
>> <jan.kratochvil@redhat.com> wrote:
>> > Hi,
>> >
>> > it is difficult to play with `set target-async on' as it usually SIGTTOU stops
>> > at various places.
>> > http://sourceware.org/bugzilla/show_bug.cgi?id=12260
>> >
>> > $ ./gdb -nx -ex 'set target-async on' -ex start ./gdb
>> > [...]
>> > Starting program: .../gdb/gdb
>> > [1]+ ?Stopped ? ? ? ? ? ? ? ? ./gdb -nx -ex 'set target-async on' -ex start ./gdb
>> >
>> > If it has a regression it IMO only means there is missing
>> > target_terminal_inferior call at some other place.
>> >
>> > No regressions on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu. ?But I was
>> > unable to reproduce the problem under DejaGnu so the regression test may not
>> > be meaningful.
>> >
>> > Not going to check it in without a review.
>> >
>>
>> Not really a review, just thought i'd mention this is also fixed by
>> the following patch
>> http://sourceware.org/ml/gdb-patches/2011-08/msg00235.html
>
> I was going to look at Jan's patch, and I'm a bit confused on the state
> of things, and the state of Matt's patch --- there was a follow up, which
> had a problem. ?Is the msg00235.html version the final one instead?

Yes, I apologize for the confusion. the follow up was intended to be
functionally equivalent
to msg00235, but getting rid of the weird empty prompt case.
Turns out the weird empty prompt case is required, A follow up to
00235 without simply
adding comments about the empty prompt case would probably have been prudent.

>> this also fixes the original report of PR 10720 which seems to be a
>> dupe, not sure about the latter reports in 10720.
>> the test cases i added do not cover this either.
>
> By "this" you mean Jan's or yours?

either really.