This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target


On Fri, 26 Aug 2011 15:48:33 +0200, H.J. Lu wrote:
> On Fri, Aug 26, 2011 at 2:25 AM, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> > -if [istarget "x86_64-*"] then {
> > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
> > Â Â set fpreg "\$rbp"
> > -} elseif [istarget "i?86-*"] then {
> > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
> > Â Â set fpreg "\$ebp"
> > Â} else {
> > Â Â set fpreg "\$fp"
> >
> 
> That is wrong for x32. X32 isn't LP64, but has 64bit registers.

I agree.  I tried to fix all the [is_lp64_target] vs. ![is_ilp32_target] cases
for x86* in the testsuite but I am not sure how x32* behaves, do you have
some qemu/kvm image with x32* toolchain?  I could not fina any on:
	http://sites.google.com/site/x32abi/


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]