Re: [PATCH,gdb,Update3]: ensures that cie ptr of an fda is a cie

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Wed, 06 Jul 2011 16:40:14 +0200, Fawzi Mohamed wrote:
> +/* Defines the type of eh_frames that are expected to be decoded: CIE, FDE
> +   or any of them. */
                    ^^^ Two spaces at the end of line.

> +
> +enum eh_frame_type
> +{
> +  EH_CIE_TYPE_ID = 1 << 0,
> +  EH_FDE_TYPE_ID = 1 << 1,
> +  EH_CIE_OR_FDE_TYPE_ID = EH_CIE_TYPE_ID + EH_FDE_TYPE_ID

A nitpick but the intended operation is | , not + .


[...]
> @@ -2102,7 +2127,7 @@
>   while (1)
>     {
>       ret = decode_frame_entry_1 (unit, start, eh_frame_p,
> -                                  cie_table, fde_table);
> +				  cie_table, fde_table,entry_type);
   				                      ^^ missing space (' ')


Thanks for the fix,
Jan