This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix `shell' command for async (PR 12850)


On Tuesday 07 June 2011 20:05:59, Joel Brobecker wrote:
> > > +++ b/gdb/rs6000-nat.c
> > > @@ -614,7 +614,7 @@ exec_one_dummy_insn (struct regcache *regcache)
> > 
> > (Urgh, had never seen this bizarre code before.  I wonder if 
> > this is still needed on any sane platform, or if it was only
> > necessary on some ancient aix.)
> 
> I think it's worth testing. 

That'd be great.  It'd get rid of another instance of
deprecated_insert_raw_breakpoint along with the bizarreness. :-)

> From the logs that I could gather,
> this function was already there in 1992 (!) but it's not entirely
> clear that it was for AIX.  But, right now, I'd have a hard time
> believing that it would be for any other kernel but AIX (the other
> ones I can see are (Linux, *BSDs).

It can only be for AIX, AFAICS.  grepping for rs6000-nat.o
only hits on gdb/config/powerpc/aix.mh --- the whole rs6000-nat.c
file is AIX only.

> The oldest AIX we have now at AdaCore is 5.2. I'm wondering if Ulrich
> might have access to something a little older?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]