This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix segfault on Python convenience functions which call GDB commands
- From: Tom Tromey <tromey at redhat dot com>
- To: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Thu, 12 May 2011 14:19:09 -0600
- Subject: Re: [RFA] Fix segfault on Python convenience functions which call GDB commands
- References: <1305085747.2308.72.camel@hactar>
>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
Thiago> 2011-05-11 Thiago Jung Bauermann <bauerman@br.ibm.com>
Thiago> gdb/
Thiago> * mi/mi-main.c (mi_cmd_execute): Use cleanup from
Thiago> prepare_execute_command.
Thiago> top.c (prepare_execute_command): Return cleanup.
Thiago> (execute_command): Use cleanup from prepare_execute_command.
Thiago> * top.h (prepare_execute_command): Change prototype to return
Thiago> cleanup.
Thiago> * defs.h (struct value): Add opaque declaration.
Thiago> (make_cleanup_value_free_to_mark): Add prototype.
Thiago> * utils.c (do_value_free_to_mark): New function.
Thiago> (make_cleanup_value_free_to_mark): Likewise.
Looks good.
Just one tiny nit.
Thiago> +extern struct cleanup * make_cleanup_value_free_to_mark (struct value *);
Extra space after the "*".
Ok with this change.
Tom