This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, testsuite] Tests to _Complex type


On Fri, 6 May 2011, Yao Qi wrote:

> When I am fixing GDB's inf-call in one port, I find tests to _Complex
> type is quite limited, especially on argument passing, there is none.
> This patch is to add more tests to _Complex type on argument passing and
> vararg support.

It would be good to include a much wider range of tests.  structs and 
unions containing complex values (and arrays of complex values, and 
complex values mixed with real ones, etc.), complex values in many 
different argument positions, and after integer arguments as well as 
floating-point ones, all three types _Complex float, _Complex double, 
_Complex long double properly covered in these ways.  For structs and 
unions and arrays therein, the sort of case you want to cover includes the 
ARM (VFP ABI) and IA64 rules on homogeneous aggregates.

(The reason I don't suggest covering complex integer types is that they 
are a GNU extension with no documented GNU DWARF extension to represent 
them.  In principle target-specific types such as __float80 and __float128 
(on x86 and IA64) and their complex versions *should* be covered, but at 
present GCC doesn't support using _Complex with those type names so 
accessing the complex versions requires using mode attributes.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]