This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Support for x86 on-stack trampolines

From: Jerome Guitton <guitton at adacore dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 4 May 2011 16:52:31 +0200
Subject: Re: [RFA] Support for x86 on-stack trampolines
References: <1304468424-2060-1-git-send-email-guitton@adacore.com> <201105040955.27810.pedro@codesourcery.com>

Pedro Alves (pedro@codesourcery.com):

> default_frame_unwind_stop_reason is only used by 
> archs/targets that don't support tracepoints at the moment.
> It shouldn't be used in any x86-specific unwinder.
> 
> If you reuse the this _frame_this_id method of the
> epilogue unwinder, you should reuse the _unwind_stop_reason
> method of the same unwinder, since you're effectively
> also reusing i386_epilogue_frame_cache.

Definitely. Thank you for catching that.

References:
- [RFA] Support for x86 on-stack trampolines
  - From: Jerome Guitton
- Re: [RFA] Support for x86 on-stack trampolines
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]