This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch 2/3] readline-6.2: Workaround "ask" regression


Hi,

testcase+discussion is:
	[patch] testsuite: Test readline-6.2 "ask" regression
	http://sourceware.org/ml/gdb-patches/2011-05/msg00002.html


Thanks,
Jan


2011-04-30  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Workaround gdb.base/completion.exp regression on readline-6.2.
	* complete.c (get_y_or_n): Disable the return on RL_STATE_CALLBACK.

--- ./readline-6.2-001/complete.c	2011-01-16 21:32:57.000000000 +0100
+++ ./readline/complete.c	2011-05-01 13:30:29.000000000 +0200
@@ -481,6 +481,10 @@ get_y_or_n (for_pager)
 {
   int c;
 
+/* Disabled for GDB due to the gdb.base/readline-ask.exp regression.
+   [patch] testsuite: Test readline-6.2 "ask" regression
+   http://sourceware.org/ml/gdb-patches/2011-05/msg00002.html  */
+#if 0
   /* For now, disable pager in callback mode, until we later convert to state
      driven functions.  Have to wait until next major version to add new
      state definition, since it will change value of RL_STATE_DONE. */
@@ -488,6 +492,7 @@ get_y_or_n (for_pager)
   if (RL_ISSTATE (RL_STATE_CALLBACK))
     return 1;
 #endif
+#endif
 
   for (;;)
     {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]