This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New ARI warning Wed Apr 27 01:54:55 UTC 2011

On 04/27/2011 09:54 AM, GDB Administrator wrote:
> 119a120
>> gdb/common/linux-ptrace.h:22: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
> gdb/common/linux-ptrace.h:22:#include <sys/wait.h>  

sys/wait.h is included for macro __WALL.  However, we can safely remove
this include from common/linux-ptrace.h because either sys/wait.h or
gdb_wait.h is included before including linux-ptrace.h in linux-nat.c
and linux-low.c.

In linux-nat.c, gdb_wait.h is included in line 25, and linux-ptrace.h is
included in line 33.  In linux-low.c, sys/wait.h is included in line 23,
and linux-ptrace.h is included in line 27.

Is it OK?

Yao (éå)
2011-04-27  Yao Qi  <>

	* common/linux-ptrace.h: Remove include <sys/wait.h>.

Index: common/linux-ptrace.h
RCS file: /cvs/src/src/gdb/common/linux-ptrace.h,v
retrieving revision 1.1
diff -u -r1.1 linux-ptrace.h
--- common/linux-ptrace.h	26 Apr 2011 15:36:04 -0000	1.1
+++ common/linux-ptrace.h	27 Apr 2011 02:52:53 -0000
@@ -19,7 +19,6 @@
 #include <sys/ptrace.h>
-#include <sys/wait.h> /* __WAIT */
 # define PTRACE_GETSIGINFO 0x4202

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]