This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC-v5] Handle cygwin wchar_t specifics

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   Hopefully I got it right this time...
 
Just a tiny nit left :)
Thanks for persevering.

Pierre> +  const char *result;

You can make this one just a "char *".
That will let you avoid casts in the xfree calls.

Pierre> +  error ("Unable to find a vaild charset for string conversions");

Needs _().

Ok with those changes.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]