This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: yao at codesourcery dot com (Yao Qi)
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 4 Mar 2011 15:08:01 +0100 (CET)
- Subject: Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing
Yao Qi wrote:
> During writing thumb displaced stepping, we find that displaced_read_reg
> can be refactored to avoid calling displaced_in_arm_mode every time.
Hmm, you now pass *both* DSC and FROM -- the latter is actually redundant
now, since every caller must pass in dsc->insn_addr as FROM anyway ...
Can you update the patch to pass DSC *instead of* FROM, and use
dsc->insn_addr internally?
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com