This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] is_name_suffix("") is always non-zero
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 28 Feb 2011 08:47:05 +0400
- Subject: Re: [PATCH] is_name_suffix("") is always non-zero
- References: <m27hcmsapy.fsf@igel.home>
> 2011-02-26 Andreas Schwab <schwab@linux-m68k.org>
>
> * ada-lang.c (compare_names): Call is_name_suffix with string1
> instead of string2.
Thanks for spotting that. Was this from code inspection, or did you
hit a bug?
Your patch does look correct to me. But the implementation of that
function is a little obscure to me - I suspect that this is because
it is meant to work in contexts other than Ada. So I asked Paul
to review your patch for me.
--
Joel