This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 1/3] Implement support for PowerPC BookE masked watchpoints


> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com,
>         brobecker@adacore.com
> Date: Sat, 27 Nov 2010 11:29:24 -0200
> 
> I just wanted to make sure that you're happy with the wording in this
> paragraph:
> 
> +* When locally debugging programs on PowerPC BookE processors running
> +  a Linux kernel version 2.6.34 or later GDB supports masked hardware
> +  watchpoints, which specifiy a mask in addition to an address to watch.
> +  The mask specifies that some bits of an address (the bits which are
> +  reset in the mask) should be ignored when matching the address accessed
> +  by the inferior against the watchpoint address.  See the "PowerPC Embedded"
> +  section in the user manual for more details.

I'm okay with it, but please put a comma after "or later".

> and also with the new "Changed commands" section that I added.

This section is fine.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]