This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: check for over- and under-flow in decode_locdesc


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> On Thu, 18 Nov 2010 22:24:27 +0100, Tom Tromey wrote:
>> +      if (stacki >= sizeof (stack) / sizeof (*stack) - 1)

Jan> I would prefer ARRAY_SIZE here (but sizeof()/sizeof() is also
Jan> common in GDB).

I'll commit it shortly with this change.

Jan> I will check in the testcase later and if OK.

I am curious to know how you made this.
Did you just write it by hand?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]