This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [doc RFA] Switch to GCC coding style [Re: [patch] initial OpenCL C language support]
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>, Ken Werner <ken at linux dot vnet dot ibm dot com>, Tom Tromey <tromey at redhat dot com>, Pedro Alves <pedro at codesourcery dot com>
- Date: Tue, 2 Nov 2010 10:29:30 -0700
- Subject: Re: [doc RFA] Switch to GCC coding style [Re: [patch] initial OpenCL C language support]
- References: <201010221920.30046.ken@linux.vnet.ibm.com> <20101026195747.GE2847@adacore.com> <20101027190417.GA19067@host1.dyn.jankratochvil.net> <201010272020.51386.pedro@codesourcery.com> <20101102165134.GA19296@host0.dyn.jankratochvil.net> <AANLkTimWg8HcVGa756vxHr=azHZTxU7KwrH+m_E+XBrV@mail.gmail.com> <20101102172246.GA22137@host0.dyn.jankratochvil.net>
On Tue, Nov 2, 2010 at 10:22 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Tue, 02 Nov 2010 18:04:39 +0100, Doug Evans wrote:
>> There are lots of things on the gcc codingconventions page that need
>> to be converted (e.g., gcc_assert),
>
> Done.
>
>> or revised (e.g., prototypes for _initialize_foo fns can appear in .c files
>> (and should *only* appear in .c files)).
>
> I do not see a current GDB doc problem with this (+it may be offtopic for this
> patch).
For reference sake I was referring to this text:
"Function prototypes for extern functions should only occur in header files."
But I see that gdbint.texinfo already does mention this exception.
My reason for mentioning it is that I suspect there are more.
Could be wrong of course.
[For reference sake, don't wait for my approval.
I'm just making suggestions (in this particular case :-)).]