This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix in data-directory

On 10/21/2010 04:13 AM, Doug Evans wrote:
On Wed, Oct 20, 2010 at 5:09 AM, Jie Zhang<> wrote:

The current install rule in the of data-directory uses recursive make but does not pass FLAGS_TO_PASS. This causes an issue when people try to override prefix with command line option "make install", i.e. data-directory will still be installed under the configure time prefix. This patch fixes it. OK?

[Apologies for the resend.]

Thanks for the bug report. Forgot about that.

This patch is not ok though.  A parallel make (e.g. -jN) might try to
build all and install-only simultaneously.

$(MAKE) install-only $(FLAGS_TO_PASS)

For reference sake, there are other instances of "install: all install-only". They need to be fixed too.

I don't think this is an issue. I think in the last more than 10 years, no one did "make -j all install" since the same instance in gdb/ has been there since it was created. Actually if you do that in current gdb, it will not install gdb at all. I usually issue

make -j4 all
make install

to make gdb. I believe people have been used to do that in this way after so many years. So I think it's not an issue to do the same for data-directory. No?

-- Jie Zhang CodeSourcery

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]