This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Rework symbol searches to move Ada-specific stuff to ada-lang.c.


>>>>> "Paul" == Paul Hilfinger <HIlfinger@cs.berkeley.edu> writes:

Paul> +	    return (*top);

Tom> A few places have parens here, but they aren't needed.
Tom> Just write "return *top;".

Paul> OK (BTW: That line was copied from the original).

Oh, ok.  I had looked to see if this was the case, but I must have
missed it.

My view is that it is always ok to leave code as-is when moving it
around.  I recommend pushing back on reviewers who ask for changes to
the context of a patch :-)

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]