This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Set MAX_REGISTER_SIZE to 64


> 2010-09-13  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* defs.h (MAX_REGISTER_SIZE): Set to 64.

I wonder if we are going to have to make this gdbarch specific,
one of these days. It's probably peanuts, but it's annoying to be
allocating 64byte buffers to store/fetch registers when the max
size on that platform is 8 or 16 bytes.

In the meantime, seems OK to me (for HEAD). I'm OK with putting
this in 7.2, but I'd like the OK from another maintainer before
you put it in 7.2, just to be on the safe side [1].

-- 
Joel

[1]: It's still unclear whether there will be another release off
     the 7.2 branch. I think something to be re-evaluated later,
     around Oct/Nov. Perhaps we can informally talk about it at
     the GCC Summit?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]