This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix DW_OP_call2 and DW_OP_call4 for max-cache-age 0
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Doug Evans <dje at google dot com>, gdb-patches at sourceware dot org
- Date: Fri, 03 Sep 2010 09:35:50 -0600
- Subject: Re: [patch] Fix DW_OP_call2 and DW_OP_call4 for max-cache-age 0
- References: <20100823185008.GA2926@host1.dyn.jankratochvil.net> <AANLkTimhw307GT1dxA5LFBnCA1njK1vk4+Sk8oamafkX@mail.gmail.com> <20100902160216.GA10848@host1.dyn.jankratochvil.net>
Jan> I would change "max-cache-age" to "max-cache-size" and call it from
Jan> prepare_execute_command() instead. I will provide a patch if not replied.
Changing it to be size-based makes sense to me.
I don't get the rationale for putting it in prepare_execute_command.
If we are flushing the cache based on memory use, then we only need to
consider flushing it just before we read a CU.
Tom