This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Code cleanup: Make function typedef for find memory region

From: Joel Brobecker <brobecker at adacore dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
Date: Tue, 31 Aug 2010 10:12:45 -0700
Subject: Re: [patch] Code cleanup: Make function typedef for find memory region
References: <20100830085953.GA25961@host1.dyn.jankratochvil.net> <20100830141454.GG2986@adacore.com> <20100830142507.GA1356@host1.dyn.jankratochvil.net> <m3tymcj69d.fsf@fleche.redhat.com> <20100831130152.GB9173@host1.dyn.jankratochvil.net> <m3occihgzj.fsf@fleche.redhat.com>

> Jan> Implementation should name the field in the interface to be able to jump
> Jan> there.
> 
> I like this idea.

The documentation I write in that case is:

    /* Implement the to_do_this target_ops method.  */

This avoid duplication, and refers back to the routine that this
function is supposed to implement.

-- 
Joel

References:
- [patch] Code cleanup: Make function typedef for find memory region
  - From: Jan Kratochvil
- Re: [patch] Code cleanup: Make function typedef for find memory region
  - From: Joel Brobecker
- Re: [patch] Code cleanup: Make function typedef for find memory region
  - From: Jan Kratochvil
- Re: [patch] Code cleanup: Make function typedef for find memory region
  - From: Tom Tromey
- Re: [patch] Code cleanup: Make function typedef for find memory region
  - From: Jan Kratochvil
- Re: [patch] Code cleanup: Make function typedef for find memory region
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]