This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Nullified garbage-collected global variables


>>>>> "Jerome" == Jerome Guitton <guitton@adacore.com> writes:

Jerome> Unless you object, I will commit this new version.
Jerome> gdb/ChangeLog:

Jerome> 	* dwarf2read.c (add_partial_symbol): Do not add a global variable if
Jerome> 	its adress is null. Add comment to explain why.
Jerome> 	(new_symbol): Ditto.

Looks ok to me.

FWIW -- I prefer it if a fix and its corresponding test case are
submitted and committed as a unit.  I think it is more logical, and also
the test case sometimes helps the review of the patch.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]