This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: ping: [patch 5/6] testsuite: Fix prelink-support.exp without prelink installed
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 5 Jul 2010 10:40:15 -0700
- Subject: Re: ping: [patch 5/6] testsuite: Fix prelink-support.exp without prelink installed
- References: <20100329161831.GD2940@host0.dyn.jankratochvil.net> <20100609150954.GE7183@host0.dyn.jankratochvil.net> <20100629220904.GV2595@adacore.com> <20100704101842.GE6875@host0.dyn.jankratochvil.net>
> GDB testsuite does not force English, neither dejagnu. But TCL seems to
> ignore locale:
That's more than good enough for me. Thanks!
> There is explicitly executed /usr/sbin/prelink because on some systems
> /usr/sbin is not in the default non-root $PATH. This also fixes:
Good point.
> Do you suggest /usr/sbin/prelink existence check, $PATH search (with
> explicitly appended `/usr/sbin') or the current error message check?
I think it's fine to wait until we actually find a system where the
current approach is not working. So:
> gdb/testsuite/
> 2010-07-04 Jan Kratochvil <jan.kratochvil@redhat.com>
> Joel Brobecker <brobecker@adacore.com>
>
> Cope with missing /usr/sbin/prelink.
> * lib/prelink-support.exp (prelink_no):
> <result == 1 && $output is "no such file or directory">: New.
> (prelink_yes): Likewise. Return on failed prelink_no.
OK to commit.
--
Joel