This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [2/4] RFC: check psymtabs_addrmap before reading FDEs


On Wed, Jun 30, 2010 at 04:37:23PM -0600, Tom Tromey wrote:
> This patch changes dwarf2_frame_find_fde to check psymtabs_addrmap
> before trying to read the FDE data.
> 
> I am not totally convinced this is safe, so comments are especially
> appreciated here.

This doesn't sound right.  I don't know how any of the psymtab changes
work, but there shouldn't be a link between psymtabs and FDEs at all;
they don't have to correspond.  Wouldn't this break a library with
.debug_frame for all code, and .debug_info for only one input object?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]