This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] windows-nat.c: Copy console information for new console
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: gdb-patches at sourceware dot org, Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Sun, 30 May 2010 13:10:41 -0400
- Subject: Re: [RFA] windows-nat.c: Copy console information for new console
- References: <001901caf934$fd580460$f8080d20$@muller@ics-cnrs.unistra.fr> <20100525205241.GA5298@ednor.casa.cgf.cx> <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr> <20100526170712.GA32594@ednor.casa.cgf.cx> <001801cafd69$018b9a00$04a2ce00$@muller@ics-cnrs.unistra.fr> <001e01cafd6c$2a0c87c0$7e259740$@muller@ics-cnrs.unistra.fr> <20100527151730.GA483@ednor.casa.cgf.cx> <001201cafe4e$e885afa0$b9910ee0$@muller@ics-cnrs.unistra.fr>
On Fri, May 28, 2010 at 12:16:59PM +0200, Pierre Muller wrote:
>> >> From Christopher Faylor
>> >> I actually thought fairly carefully about flags. If you have a
>> >> function
>> >> which controls console info, then the function should set the flags
>> >> appropriately to deal with the console info.
>> >
>> >
>> > As you prefer,
>> >here is a new version that also takes DWORD *flags as parameter.
>> > I also tried to explain a little bit better
>> >what the function tries to do.
>>
>> Thanks. Looks good. I forgot to say: Thanks for doing this. It
>> looks like
>> a nice improvement.
>
> Hi Christopher,
> does this mean that you want to test it
>a little bit more before you give some more detailed
>review or should I understand this as an approval?
Wow. You like to go back and forth don't you?
Just apply it already.
cgf