This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] windows-nat.c: Copy console information for new console


On Fri, May 28, 2010 at 12:16:59PM +0200, Pierre Muller wrote:
>> >> From Christopher Faylor
>> >> I actually thought fairly carefully about flags.  If you have a
>> >> function
>> >> which controls console info, then the function should set the flags
>> >> appropriately to deal with the console info.
>> >
>> >
>> >  As you prefer,
>> >here is a new version that also takes DWORD *flags as parameter.
>> >  I also tried to explain a little bit better
>> >what the function tries to do.
>> 
>> Thanks.  Looks good.  I forgot to say:  Thanks for doing this.  It
>> looks like
>> a nice improvement.
>
>  Hi Christopher,
>  does this mean that you want to test it
>a little bit more before you give some more detailed
>review or should I understand this as an approval?

Wow.  You like to go back and forth don't you?

Just apply it already.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]