This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] New qRelocInsn RSP packet, docs and NEWS.
On Thursday 27 May 2010 20:58:02, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> Index: src/gdb/remote.c
> Pedro> ===================================================================
> Pedro> --- src.orig/gdb/remote.c 2010-05-24 12:28:42.000000000 +0100
> Pedro> +++ src/gdb/remote.c 2010-05-24 13:14:56.000000000 +0100
> Pedro> @@ -242,6 +242,8 @@ static void remote_terminal_ours (void);
>
> Pedro> static int remote_read_description_p (struct target_ops *target);
>
> Pedro> +char *unpack_varlen_hex (char *buff, ULONGEST *result);
>
> It seems like this declaration could go in tracepoint.h.
This function does live in remote.c, but it's defined further down, close to
its siblings. tracepoint.c is also reusing it since not to long ago (since
tracing moved to target_ops). remote.h would make a bit more sense though
one could argue it could also live in a shared utils.c-kind of file nowadays.
--
Pedro Alves