This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Expand description of solib-svr4.c:solib_svr4_r_map
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 27 Apr 2010 14:12:53 -0700
- Subject: [commit] Expand description of solib-svr4.c:solib_svr4_r_map
This patch just expands the description of one of the functions to
describe what happens in case the map address cannot be determined...
If there is a pool for best-patch-of-the-year, can this one have
my vote? :-)
2010-04-27 Joel Brobecker <brobecker@adacore.com>
* solib-svr4.c (solib_svr4_r_map): Expand function description.
Checked in.
---
gdb/ChangeLog | 4 ++++
gdb/solib-svr4.c | 3 ++-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8a45894..b5ca30f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2010-04-27 Joel Brobecker <brobecker@adacore.com>
+ * solib-svr4.c (solib_svr4_r_map): Expand function description.
+
+2010-04-27 Joel Brobecker <brobecker@adacore.com>
+
* symfile.c (init_filename_language_table): Register .dg files
with language_ada.
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 3ff4243..1928af0 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -869,7 +869,8 @@ locate_base (struct svr4_info *info)
}
/* Find the first element in the inferior's dynamic link map, and
- return its address in the inferior.
+ return its address in the inferior. Return zero if the address
+ could not be determined.
FIXME: Perhaps we should validate the info somehow, perhaps by
checking r_version for a known version number, or r_state for
--
1.6.3.3