This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] support argument dependent lookup (ADL)
- From: Tom Tromey <tromey at redhat dot com>
- To: Sami Wagiaalla <swagiaal at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 23 Apr 2010 16:34:45 -0600
- Subject: Re: [patch] support argument dependent lookup (ADL)
- References: <4BA7D08C.5070702@redhat.com> <m3vdcdvau0.fsf@fleche.redhat.com> <1270829129.2387.23.camel@localhost>
- Reply-to: tromey at redhat dot com
>>>>> "Sami" == Sami Wagiaalla <swagiaal@redha.com> writes:
Sami> I have added tests for all of the above situations.
Thanks.
Sami> 2010-04-09 Sami Wagiaalla <swagiaal@redhat.com>
Sami> PR C++/7943:
Sami> * valops.c (find_overload_match): Handle fsym == NULL case.
Sami> Add int no_adl argument.
Sami> (find_oload_champ_namespace_loop): Call make_symbol_overload_list_adl
[...]
This ChangeLog entry and the one in the patch are different.
Sami> + write_exp_elt_sym (NULL); /* Place holder */
A nit, "placeholder" is one word.
Also, end with a period & double space.
Sami> + while (TYPE_CODE (type) == TYPE_CODE_PTR || TYPE_CODE (type) == TYPE_CODE_REF
Sami> + || TYPE_CODE (type) == TYPE_CODE_ARRAY)
Sami> + type = TYPE_TARGET_TYPE (type);
I think you need a check_typedef in the loop. Otherwise in some
situations with typedefs I think you can end up with type==NULL.
This is ok with those changes. Thanks.
Could you submit a followup patch that adds a NEWS entry?
Tom