This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: Explanation: New ARI warning Wed Apr 21 01:54:25 UTC 2010
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Cc: "'Joel Brobecker'" <brobecker at adacore dot com>
- Date: Wed, 21 Apr 2010 10:01:22 +0200
- Subject: RE: Explanation: New ARI warning Wed Apr 21 01:54:25 UTC 2010
- References: <20100421015425.GA10145@sourceware.org> <001801cae125$cac33230$60499690$@muller@ics-cnrs.unistra.fr>
Whoops, I forgot ONE big limitation
that might apply to today's email.
> > 1072a1071
> > > gdb/procfs.c:4090: code: sprintf: Do not use sprintf, instead use
> > xstrprintf
> > gdb/procfs.c:4090: sprintf (name, ', pi->pid, map->pr_mapname);
> > 1100d1098
> > < gdb/procfs.c:5659: code: sprintf: Do not use sprintf, instead use
> > xstrprintf
> > gdb/procfs.c:5659: sprintf (name, ', pi->pid, map->pr_mapname);
I wasn't careful enough:
The first 1072 is with '>' meaning new,
but the second is '<' meaning removal.
Moreover the two lines are identical which probably means that
this is just due to reordering.
Thus the total number of 'sprintf' uses did not change
but the reordering of the functions that Joel
made lead to this email.
My apologies to Joel.
So this reveals already a limitation
of the script: If you move function around,
it becomes difficult to realize for the script that this is
only a move, and no new warning.
Sorry for my wrong first explanation,
Pierre