This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA-v2] Fix cygwin compilation failure for python code


> Pierre>   I wonder why I am the only one having this
> Pierre> problem?
> 
> Me too.
 Glad to hear that I am not the only one ...
 
> Pierre>   Is this patch OK? Otherwise,
> Pierre> how should such problems be handled?
> 
> I would recommend just including symtab.h from python-internal.h.

You are right, this is easier,
but I was suspecting that the 
original writers of this header
wanted it to NOT depend on any real gdb header...

  Anyway, here is a new version of the
compilation failure fix.
  Python is not even mentioned in MAINTAINERS...
  
  Is this version OK?

Pierre Muller

gdb/ChangeLog entry:

2010-03-09  Pierre Muller  <muller@ics.u-strasbg.fr>

	* python/python-internal.h: Include symtab.h.

Index: python-internal.h
===================================================================
RCS file: /cvs/src/src/gdb/python/python-internal.h,v
retrieving revision 1.21
diff -u -p -r1.21 python-internal.h
--- python-internal.h	24 Feb 2010 21:18:27 -0000	1.21
+++ python-internal.h	9 Mar 2010 14:44:56 -0000
@@ -61,9 +61,11 @@ typedef int Py_ssize_t;
 #define PyEval_ReleaseLock() 0
 #endif
 
+/* In order to be able to parse symtab_and_line_to_sal_object function 
+   a real symtab_and_line structure is needed.  */
+#include "symtab.h"
+
 struct block;
-struct symbol;
-struct symtab_and_line;
 struct value;
 struct language_defn;
 



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]