This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] infcall: Remove gdb_assert ($sp underflow)
On Sat, Feb 27, 2010 at 01:46:34AM +0100, Jan Kratochvil wrote:
> The tests have been already producing:
>
> PASS: gdb.base/callfuncs.exp: sp=0: set $old_sp = $sp
> PASS: gdb.base/callfuncs.exp: sp=0: set $sp = 0
> PASS: gdb.base/callfuncs.exp: sp=0: call doubleit (1)
> PASS: gdb.base/callfuncs.exp: sp=0: set $sp = $old_sp
> PASS: gdb.base/callfuncs.exp: sp=-1: set $old_sp = $sp
> PASS: gdb.base/callfuncs.exp: sp=-1: set $sp = -1
> PASS: gdb.base/callfuncs.exp: sp=-1: call doubleit (1)
> PASS: gdb.base/callfuncs.exp: sp=-1: set $sp = $old_sp
>
Oh, you're right. I missed pf_prefix. Either way is fine with me.
> + gdb_test {sp == 0: call doubleit (1)}
Except what does this do? I've never seen this syntax before, I'm
surprised that it works.
I think the patch is otherwise OK.
--
Daniel Jacobowitz
CodeSourcery