This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] More linespec quoting "fixes"
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 26 Feb 2010 16:02:49 -0700
- Subject: Re: [RFA] More linespec quoting "fixes"
- References: <4B85A3BF.8010001@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Daniel recently committed a patch which fixed a couple of
Keith> linespec inconsistencies (allow "file:'function'" and
Keith> "'file:function'").
Keith> I wonder why not also allow "'file':function" and
Keith> "'file':'function'"?
Keith> I couldn't find a good answer as to why these two forms would be
Keith> disallowed, so I'm submitting the attached patch to enable these
Keith> formats.
The patch seems reasonable enough to me. But, I don't claim to
understand linespec.c, so I'd appreciate it if someone else would take a
look.
My real question is whether we want to do this. We've talked a little
bit about rewriting linespec to be less horrible... will supporting more
syntax make this too hard? I'm open to breaking compatibility a bit --
but I think there is a limit to what we can do there, based on what is
documented.
Tom