This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: pr 11067 patch

From: Joel Brobecker <brobecker at adacore dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Chris Moller <cmoller at redhat dot com>, gdb-patches at sourceware dot org
Date: Fri, 12 Feb 2010 08:11:37 +0400
Subject: Re: pr 11067 patch
References: <4B737180.4050802@redhat.com> <20100211092950.GC2907@adacore.com> <m3wryjr1r0.fsf@fleche.redhat.com>

> If you disagree strongly, then we could just close the PR and drop it, I
> suppose.  I am not very intent on this, I just thought it would be a
> nice, if minor, enhancement.  I didn't see a real downside.

Not at all, I cannot say I like the idea, but if it's useful to others,
this is all that really matters. Let's go ahead, then.

Regarding GNU indent - I know. But I try to keep formatting the code
the way GNU indent would do it in sane situations, as it helps keeping
some uniformity to our code.  There are some rules I don't like (ahem,
ask me about spaces and tabs), but I think that uniformity is more
important...

I'm happy I contributed just a little bit towards this patch - I really
felt bad reacting to it so so late in the game.

-- 
Joel

Follow-Ups:
- Re: pr 11067 patch
  - From: Chris Moller

References:
- pr 11067 patch
  - From: Chris Moller
- Re: pr 11067 patch
  - From: Joel Brobecker
- Re: pr 11067 patch
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]