This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Cache types from target description

From: Daniel Jacobowitz <dan at codesourcery dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GDB <gdb-patches at sourceware dot org>, Mark Kettenis <mark dot kettenis at xs4all dot nl>
Date: Wed, 10 Feb 2010 13:38:03 -0500
Subject: Re: PATCH: Cache types from target description
References: <20100205011447.GA28263@lucon.org> <20100208185454.GA21449@lucon.org> <20100209154513.GA27404@lucon.org>

On Tue, Feb 09, 2010 at 07:45:13AM -0800, H.J. Lu wrote:
> 2010-02-09  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* target-descriptions.c (tdesc_type): Add TDESC_TYPE_I387_EXT,
> 	TDESC_TYPE_I386_EFLAGS and TDESC_TYPE_I386_MXCSR.
> 	(tdesc_predefined_types): Add i387_ext, i386_eflags and
> 	i386_mxcsr.
> 	(tdesc_find_type): New.
> 	(tdesc_gdb_type): Use tdesc_find_type.  Handle TDESC_TYPE_I387_EXT,
> 	TDESC_TYPE_I386_EFLAGS and TDESC_TYPE_I386_MXCSR.
> 
> 	* target-descriptions.h (tdesc_find_type): New.

This is OK.  I am not happy having the flag types in this file, but
I don't see a better way yet.  Really they should be described in the
XML file!

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: PATCH: Cache types from target description
  - From: Mark Kettenis

References:
- PATCH: PATCH: Add builtin floating point types
  - From: H.J. Lu
- PATCH: Cache types from target description
  - From: H.J. Lu
- Re: PATCH: Cache types from target description
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]