This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PATCH: Add builtin floating point types


On Sun, Feb 07, 2010 at 09:16:25PM -0800, H.J. Lu wrote:
> in gdbtypes.c. struct arch_type will have
> 
> struct type *arch_ieee_single;
> struct type *arch_ieee_double;
> struct type *arch_i387_ext;
> 
> They will be lazy initialized. I thought that was what you suggested.

This hasn't changed anything; it still has to know about i387_ext.

There are at least two options.  We could use a per-gdbarch hash table
to cache the result of arch_float_type (in arch_float_type, not in its
caller).  Or we could put the cache in tdesc_gdb_type, which is
probably easier.

There's already an ARM-specific type there.  It's there because the
XML format already has to know the magic arch-specific names and
document them in the GDB manual appendix.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]