This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
FYI: remove gnu-v2-abi.h
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 02 Feb 2010 10:09:08 -0700
- Subject: FYI: remove gnu-v2-abi.h
- Reply-to: tromey at redhat dot com
I'm checking this in.
I noticed that we have gnu-v2-abi.h, but no real need for it. It
declares a single function which can be static, and it is only included
in a single place.
Tested by rebuilding gdb.
Tom
2010-02-02 Tom Tromey <tromey@redhat.com>
* gnu-v2-abi.c: Don't include gnu-v2-abi.h.
(gnuv2_baseclass_offset): Now static.
* Makefile.in (HFILES_NO_SRCDIR): Remove gnu-v2-abi.h.
* gnu-v2-abi.h: Remove.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1109
diff -u -r1.1109 Makefile.in
--- Makefile.in 14 Jan 2010 08:03:35 -0000 1.1109
+++ Makefile.in 2 Feb 2010 16:56:26 -0000
@@ -706,7 +706,7 @@
osf-share/cma_stack_int.h osf-share/cma_init.h \
osf-share/cma_deb_core.h osf-share/AT386/cma_thread_io.h \
osf-share/cma_sched.h proc-utils.h arm-tdep.h ax-gdb.h ppcnbsd-tdep.h \
-cli-out.h gdb_expat.h breakpoint.h infcall.h obsd-tdep.h gnu-v2-abi.h \
+cli-out.h gdb_expat.h breakpoint.h infcall.h obsd-tdep.h \
exec.h m32r-tdep.h osabi.h gdbcore.h solib-som.h \
i386bsd-nat.h xml-support.h xml-tdesc.h alphabsd-tdep.h gdb_obstack.h \
ia64-tdep.h ada-lang.h varobj.h frv-tdep.h nto-tdep.h serial.h \
Index: gnu-v2-abi.c
===================================================================
RCS file: /cvs/src/src/gdb/gnu-v2-abi.c,v
retrieving revision 1.35
diff -u -r1.35 gnu-v2-abi.c
--- gnu-v2-abi.c 1 Jan 2010 07:31:32 -0000 1.35
+++ gnu-v2-abi.c 2 Feb 2010 16:56:26 -0000
@@ -28,7 +28,6 @@
#include "demangle.h"
#include "cp-abi.h"
#include "cp-support.h"
-#include "gnu-v2-abi.h"
#include <ctype.h>
@@ -346,7 +345,7 @@
-1 is returned on error. */
-int
+static int
gnuv2_baseclass_offset (struct type *type, int index,
const bfd_byte *valaddr, CORE_ADDR address)
{
Index: gnu-v2-abi.h
===================================================================
RCS file: gnu-v2-abi.h
diff -N gnu-v2-abi.h
--- gnu-v2-abi.h 1 Jan 2010 07:31:32 -0000 1.8
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,27 +0,0 @@
-/* Abstraction of GNU v2 abi.
-
- Copyright (C) 2005, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
-
- This file is part of GDB.
-
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 3 of the License, or
- (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>. */
-
-#ifndef GNU_V2_ABI_H
-#define GNU_V2_ABI_H
-
-extern int gnuv2_baseclass_offset (struct type *type, int index,
- const bfd_byte *valaddr,
- CORE_ADDR address);
-
-#endif