This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Test cases nsusing.exp and nsrecurs.exp
- From: Tom Tromey <tromey at redhat dot com>
- To: Sami Wagiaalla <swagiaal at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 27 Jan 2010 16:01:55 -0700
- Subject: Re: [patch] Test cases nsusing.exp and nsrecurs.exp
- References: <4B609E5F.9060008@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:
Sami> This patch contains the remainder of the nsusing.exp and nsrecurs.exp
Sami> test cases. Committing entire test cases makes it easier to manage
Sami> patches and avoids creation of unneeded conflicts. I have patches for
Sami> all the kfails.
I think it is more usual to submit the patches as a series, with the
test cases being one part, or to split them up. I don't really have a
problem with it this time, since I know you'll be sending them soon, but
next time this would be better.
What I do is make a private branch in git and make each commit a
separate submittable patch; then I rebase and/or edit the history as
needed.
Sami> +gdb_test "print _a" "No symbol \"_a\" in current context." "Print _a without import"
There are a few over-long lines like this. Break them up like:
gdb_test "print _a" "No symbol \"_a\" in current context." \
"Print _a without import"
Ok with that change.
Tom