This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/commit 3/4] symfile.c:free_named_symtabs body is commented out...
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> The entire body of free_named_symtabs is commented out, and it looks
Joel> like it has been this way since CVS day 1...
Joel> The issue is that there is another function, cashier_psymtab, which
Joel> isn't used anywhere except in the commented-out implementation of
Joel> free_named_symtabs. This generates a -Wunused-function warning.
Joel> For now, I did not delete the code, but commented out, along with the rest
Joel> of the code that was already commented out as well. We'll need to decide
Joel> what to do. Is this a hole in our implementation, or something that can
Joel> now go?...
I think we don't need this code.
I suppose in theory we could allocate psymtabs with malloc and delete
them when they are expanded. I'm not sure this is really worth the
bother. And, if it is, these functions are just the tiniest part of the
patch that would be needed. Deleting them won't seriously impede
anybody.
Tom