This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/2] Perform a namespace lookup at every block level
- From: Tom Tromey <tromey at redhat dot com>
- To: Sami Wagiaalla <swagiaal at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 21 Dec 2009 14:55:14 -0700
- Subject: Re: [patch 2/2] Perform a namespace lookup at every block level
- References: <4A57512A.7090208@redhat.com> <20090710194949.GA2064@caradoc.them.org> <4A5B68A4.30006@redhat.com> <4A68B91D.2080206@redhat.com> <4A8B0FD9.7010603@redhat.com> <4AA14648.7090600@redhat.com> <m3iqejjb7a.fsf@fleche.redhat.com> <4AE09A10.9040703@redhat.com> <m3ocna801w.fsf@fleche.redhat.com> <4B019120.7090504@redhat.com> <4B0C3011.4080000@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:
Sami> Updating patch because of changes in patch 1/2
Sami> 2009-11-16 Sami Wagiaalla <swagiaal@redhat.com>
Sami> * cp-namespace.c (cp_lookup_symbol_namespace): Added
Sami> search_parent argument.
Sami> (cp_add_using): Initialize 'searched' field.
Sami> (cp_copy_usings): Copy searched field.
Sami> * cp-support.h: Add 'searched' field to using_direct struct.
Sami> (cp_lookup_symbol_imports): Ditto.
Sami> * cp-namespace.c (cp_lookup_symbol_imports): Ditto.
Sami> Perform recursive search.
Sami> Implement non parent search.
Sami> * valops.c (value_maybe_namespace_elt): Updated.
This is nearly ok.
Note that the patch got a little mangled, and this resubmission was
missing the changes in testsuite/.
Sami> 2009-11-16 Sami Wagiaalla <swagiaal@redhat.com>
Sami> * gdb.cp/namespace-stress.exp: New test.
Sami> * gdb.cp/namespace-stress.cc: New test program.
Sami> * gdb.cp/namespace-recursive.exp: New test.
Sami> * gdb.cp/namespace-recursive.cc: New test program.
Sami> * gdb.cp/namespace-stress.exp: New test.
Sami> * gdb.cp/namespace-stress.cc: New test program.
We're mostly following 8.3 rules, so I would suggest renaming these to
"ns-*".
Also, in an archer fix you had namespace-stress-declaration... what
happened to that? The corresponding code patch seems to include
reset_directive_searched:
http://sourceware.org/ml/archer-commits/2009-q4/msg00094.html
Speaking of which, reset_directive_searched is not mentioned in the
ChangeLog.
Tom