This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ob] fix buf size in amd64_epilogue_frame_cache
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 21 Dec 2009 08:38:09 +0400
- Subject: Re: [ob] fix buf size in amd64_epilogue_frame_cache
- References: <4B2E762E.7060302@vmware.com>
> 2009-12-20 Michael Snyder <msnyder@vmware.com>
>
> * amd64-tdep.c (amd64_epilogue_frame_cache): Fix buf size.
I'm going to apply this patch to the gdb-7.0 branch as well.
> - gdb_byte buf[4];
> + gdb_byte buf[8];
I think we should try to avoid using litteral constants like these,
especially when we repeat that constant later. For instance, in
this case, we could have used register_size, or something similar...
--
Joel