This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix gdb 7.0 compilation on IRIX 5.3

Tom Tromey <> writes:

>>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> Rainer> 2009-11-23  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> Rainer> 	* dwarf2read.c [HAVE_MMAP] (MAP_FAILED): Define if missing.
> Rainer> +#ifndef MAP_FAILED
> Rainer> +#define MAP_FAILED -1
> Rainer> +#endif
> I would have expected `(void *) -1' here.  This is ok if it was
> warning-free.  Or the other form is also ok.

I didn't see the warning, and used the cast-free form since gcc had
both.  I notice now that they use casts to char * when MAP_FAILED is

Could you check this in for me?  I couldn't check out an rw cvs tree from, although I should have rw access to src.

ro@manam 443 > cvs -d co gdb
Permission denied (publickey,gssapi-with-mic).
cvs [checkout aborted]: end of file from server (consult above messages if any)

Btw, the crashes I've observed were already known: PR gdb/10819.


Rainer Orth, Center for Biotechnology, Bielefeld University

RCS file: gdb/RCS/dwarf2read.c,v
retrieving revision 1.1
diff -up -r1.1 gdb/dwarf2read.c
--- gdb/dwarf2read.c	2009/09/15 16:09:32	1.1
+++ gdb/dwarf2read.c	2009/11/23 20:36:20
@@ -58,6 +58,9 @@
 #ifdef HAVE_MMAP
 #include <sys/mman.h>
+#ifndef MAP_FAILED
+#define MAP_FAILED ((void *) -1)
 #if 0

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]